Skip to content

fix: update 'Platform Engineer' icon color#357

Merged
yada merged 3 commits intomicrocks:masterfrom
alikhere:fix/platform-engineer-icon-color
Feb 23, 2025
Merged

fix: update 'Platform Engineer' icon color#357
yada merged 3 commits intomicrocks:masterfrom
alikhere:fix/platform-engineer-icon-color

Conversation

@alikhere
Copy link
Contributor

@alikhere alikhere commented Feb 22, 2025

Description

  • Updated the "For Platform Engineer" icon color to match other role icons (deep blue/light blue).
  • Improved accessibility and readability by ensuring the icon has better contrast, making it easier to differentiate for all users, especially those with visual impairments.
  • Ensured consistency in the visual appearance of role icons, creating a more cohesive user experience.

Related issue(s)

Fixes #354

Screenshots

Before:

Screenshot from 2025-02-23 02-20-29

After:

Screenshot from 2025-02-23 02-21-03

Screenshot from 2025-02-23 02-26-35

Checklist

  • Followed the contribution guidelines.
  • Tested the changes and confirmed functionality.
  • Updated the relevant documentation.

Additional Notes

  • Let me know if any further adjustments or improvements are needed.

@alikhere
fix: update'Platform Engineer' icon color
38b2601 
Signed-off-by: alikhere <alikhurshidhere@gmail.com>
yada
yada requested changes Feb 23, 2025
View reviewed changes
Copy link
Member

@yada yada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-use platform-engineer.png instead of adding a new image

@yada
Copy link
Member

yada commented Feb 23, 2025

@yada okk

Thank you. This is to avoid having old files all around the repo for nothing ;)

@alikhere
Copy link
Contributor Author

alikhere commented Feb 23, 2025

you want to use old icon image and remove the newer one which i have added or just rename new file as platform-engineer.png and remove older one ?

@yada
Copy link
Member

yada commented Feb 23, 2025

you want to use old icon image and remove the newer one which i have added or just rename new file as platform-engineer.png and remove older one ?

Use the same name for the new image to overwrite the old image.

@alikhere
Copy link
Contributor Author

alikhere commented Feb 23, 2025 •
edited
Loading

cool !

@yada
Copy link
Member

yada commented Feb 23, 2025

@Mayaleeeee is this color aligned with your suggestions?

@Mayaleeeee
Copy link

Mayaleeeee commented Feb 23, 2025

Thanks for making this update! 🙌 @yada

The new color looks great and aligns with what I had in mind—it looks much more accessible now!

@alikhere
fix: rename newer platform icon image and remove the older one
1cfad6e 
Signed-off-by: alikhere <alikhurshidhere@gmail.com>
@alikhere
Copy link
Contributor Author

alikhere commented Feb 23, 2025

@yada Changes are made as requested

yada
yada approved these changes Feb 23, 2025
View reviewed changes
Copy link
Member

@yada yada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with thanks

@yada yada self-assigned this Feb 23, 2025
@yada yada merged commit 196f6c6 into microcks:master Feb 23, 2025
5 checks passed
alikhere added a commit to alikhere/microcks.io that referenced this pull request Feb 26, 2025
@alikhere
fix: update 'Platform Engineer' icon color (microcks#357)
d9d20f2 
* fix: update'Platform Engineer' icon color

Signed-off-by: alikhere <alikhurshidhere@gmail.com>

* fix: rename newer platform icon image and remove the older one

Signed-off-by: alikhere <alikhurshidhere@gmail.com>

---------

Signed-off-by: alikhere <alikhurshidhere@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yada yada yada approved these changes

Assignees

@yada yada

Labels

component/documentation kind/enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve Accessibility of the "For Platform Engineer" Icon Color in the Microcks Documentation

3 participants

@alikhere @yada @Mayaleeeee